724584 - ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr' in imgRequest::Init

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

xul.dll!nsCOMPtr<nsIRequest>::Assert_NoQueryNeeded()  Line 532 + 0x2a bytes	C++
xul.dll!nsCOMPtr<nsIRequest>::operator=(nsIRequest * rhs)  Line 653	C++
xul.dll!imgRequest::Init(nsIURI * aURI, nsIURI * aCurrentURI, nsIRequest * aRequest, nsIChannel * aChannel, imgCacheEntry * aCacheEntry, void * aLoadId, nsIPrincipal * aLoadingPrincipal, int aCORSMode)  Line 162	C++
 	xul.dll!imgCacheValidator::OnStartRequest(nsIRequest * aRequest, nsISupports * ctxt)  Line 2211	C++

The JS Stack ends with PageThumbsProtocol.js::Channel_startRequest

Joe thinks it's due to the third argument here that should be aRequest and not the channel.
http://mxr.mozilla.org/mozilla-central/source/image/src/imgLoader.cpp#2207

Comment 1

[Joe Drew (not getting mail)]

Attachment: use nsIRequest

I'm pretty sure that just using inheritance breaks XPCOM rules; luckily, we have this existing nsIRequest lying around.

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c7130f50c21

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/1c7130f50c21