Closed
Bug 724615
Opened 12 years ago
Closed 12 years ago
Fix TARGET_CPU usage on ARM
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: armin76, Assigned: armin76)
Details
Attachments
(1 file)
749 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
xpcom/glue/objs.mk uses a generic 'arm' to check whether to build an ARM-specific object file or not. The checks are done using "ifeq (arm,$(TARGET_CPU))", this would only work on Linux on those cases where the compiler has a CTARGET like arm-none-linux-gnueabi. Some other distros(gentoo, f.ex) use specific triplets for the different ARM subarchitectures, f.ex armv7a-unknown-linux-gnueabi, therefore making this check useless. With the patch i'm attaching i'm doing the same approach as xpcom/reflect/xptcall/src/md/unix/Makefile.in, although in that case it uses OS_TEST and not TARGET_CPU, but the problem is the same as OS_TEST on ARM is ${target_cpu}.
Assignee | ||
Updated•12 years ago
|
Attachment #594755 -
Flags: review?(benjamin)
Updated•12 years ago
|
Attachment #594755 -
Flags: review?(benjamin) → review+
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → armin76
Keywords: checkin-needed
Comment 1•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/d05120728598
Keywords: checkin-needed
Target Milestone: --- → mozilla13
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d05120728598
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•