724855 - Add the missing nsIObserver interface to nsSmsManager

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 595003 [details] [diff] [review]
Patch

Review of attachment 595003 [details] [diff] [review]:
-----------------------------------------------------------------

This has nothing to do with Android.
Wonder why you asked the review to an Android peer....

Comment 3

[Mounir Lamouri (:mounir)]

For a bit of context: I wrote that patch but on Vivien's laptop, that's why he did attach it but the patch has my name.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

For more context, this patch fix an assertion that I hit when running Gaia's tests.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 595003 [details] [diff] [review]
Patch

Why wasn't this noticed before?

Comment 6

[Mounir Lamouri (:mounir)]

Comment on attachment 595003 [details] [diff] [review]
Patch

I don't know why I haven't seen that during my tests. I guess the assert must have been lost in the logcat spam. Things seemed to work though.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5c587c490cd7