724886 - Push images from plugins instead of pulling from nsObjectFrame

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Bas Schouten (:bas.schouten)]

As we progress om making the NPAPI Async extension work, we need to push images from the plugin code rather than pulling them from nsObjectFrame. That way the plugin code can also update the images on the container as new surfaces are set current.

Now that the refactoring of image containers is done so that they are layermanager independent we can do this.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Push images instead of pulling

This patch should do the trick, the MacIOSurface path could be made to work a little bit more optimal now that we push instead of pull, but since this shouldn't cause any regressions I suggest we do that in a followup.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 595105 [details] [diff] [review]
Push images instead of pulling

Review of attachment 595105 [details] [diff] [review]:
-----------------------------------------------------------------

Nice

::: dom/plugins/ipc/PluginInstanceParent.h
@@ +299,5 @@
>      // |aSize|.  Return true if successful.
>      bool CreateBackground(const nsIntSize& aSize);
>      void DestroyBackground();
>      SurfaceDescriptor BackgroundDescriptor() /*const*/;
> +    mozilla::layers::ImageContainer *GetImageContainer();

Add a typedef to make this prefixing go away

Comment 3

[Bas Schouten (:bas.schouten)]

Attachment: Push images instead of pulling v2

Some issues found during testing were fixed. We now deal with an instance going away due to plugin crashing causing no container to be found, and some of the mac code was fixed up to compile/behave correctly.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1a345b043b47