724948 - test_bug720538 fails on some screen sizes

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

On some devices test_bug720538 fails because the screen is large enough to include the iframe in the bottom-right corner, messing up the pixel check. The pixel check isn't technically needed, so we can just take it out.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 595057 [details] [diff] [review]
Patch

Review of attachment 595057 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me.  Any danger in this failing on a different screen size for the one pixel we still are checking?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I don't think the remaining pixel check can fail on a different screen size; the other iframe is way off to the right. The only other thing in that area is the scrollbar which might interfere but would do so consistently across all devices and would have showed up in my testing.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c7041f59ef5

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7c7041f59ef5

Comment 5

[Paul Feher]

Verified on:
Nightly Fennec 13.0a1 (2012-03-04)
Device: HTC Desire Z
OS: Android 2.3.3