72495 - libjar/"regexp" cleanup

Status: VERIFIED FIXED

(Core :: Networking: JAR, defect, P3)

Description

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I'm trying to get rid of the old crap in mozilla/include, and xp_regexp points
at the libjar stuff.

I have a patch that makes it all go away, and renames the XP_RegExp functions to
be NS_WildCard to make the filenames and to avoid misrepresenting their
functionality.

Also, I fixed an error code mismatch between standalone and regular builds, and
generally tidied a little.

Comment 1

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Attachment: libjar patch

Comment 2

[Daniel Veditz [:dveditz]]

r=dveditz

Comment 3

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Fixed!  Thanks.

Comment 5

[Grace Bush]

verified code fix

Comment 6

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Dammit, I missed (the last) two xp_regexp.h references.

Looking for quick r and sr.

Comment 7

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Attachment: stragglers be gone!

Comment 8

[Brian Ryner (not reading)]

r=bryner on the last patch

Comment 9

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 10

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Fixed.

Comment 11

[Grace Bush]

verify code fixes