725105 - Fix non-OS-double-buffered GL layers

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Joe Drew (not getting mail)]

Attachment: Invert texture coordinates

The single-buffering path is broken right now, but this fixes it.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

You rock! Does non-OS-double-buffering work on B2G with that patch?

Comment 2

[Joe Drew (not getting mail)]

Not really, unfortunately. We still get some bad rendering. More investigation is necessary.

Comment 3

[Andreas Gal :gal]

Oh wow this could be great. Can you test switching off double buffering by flipping that bool and applying this patch? We desperately need that to stop tearing.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We need this patch as insurance against what appear to be driver bugs, so it's quite high priority for b2g.  What's the status here?  Not ready for review yet?

Comment 5

[Joe Drew (not getting mail)]

Note that even if you apply this patch, you still need to turn off double buffering at GLContextProviderEGL.cpp:2016 before it'll take effect.

Comment 6

[Joe Drew (not getting mail)]

Finally got a test build up on the Maguro device while using single buffering. Still shows problems (flashing the lock screen this time), which implies that the problem is a fundamental one involving FBOs on the Maguro's drivers.

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 595192 [details] [diff] [review]
Invert texture coordinates

Review of attachment 595192 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I apparently forgot to r+ this.

Comment 8

[Joe Drew (not getting mail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/571e46266e96

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/571e46266e96