Closed
Bug 725138
Opened 12 years ago
Closed 12 years ago
tidy up formal access, remove dead Stack code
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: luke, Assigned: luke)
Details
Attachments
(2 files)
16.23 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
4.81 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Just flushing out some built-up cleanup patches from farther-out patches.
Assignee | ||
Comment 1•12 years ago
|
||
This patch - undoes more of the changes from the old Stack/StackSpace split, - removes resetCallFrame; it is dead (didn't I already do this?) - kills these initJitFrame* functions since they don't actually describe what the prologue is doing anymore, merging two of them into initFixupFrame, since that is actually used (by getFixupFrame in FixupArity).
Attachment #595235 -
Flags: review?(bhackett1024)
Assignee | ||
Comment 2•12 years ago
|
||
Tiny patch, just uses formalArg (useful later when arg access is more dynamic) and adds localSlot for symmetry.
Attachment #595236 -
Flags: review?(bhackett1024)
Updated•12 years ago
|
Attachment #595235 -
Flags: review?(bhackett1024) → review+
Updated•12 years ago
|
Attachment #595236 -
Flags: review?(bhackett1024) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ede0c5fcdbad https://hg.mozilla.org/integration/mozilla-inbound/rev/7d6b0f4c1bc0
Target Milestone: --- → mozilla13
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ede0c5fcdbad https://hg.mozilla.org/mozilla-central/rev/7d6b0f4c1bc0
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•