725210 - Add internal observer notification for last PB docshell going away

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Comment 1

[Josh Matthews [:jdm]]

Attachment: <required>

Comment 2

[Josh Matthews [:jdm]]

Attachment: Add observer notification for last PB docshell going away.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 595319 [details] [diff] [review]
Add observer notification for last PB docshell going away.

Seems ok, but do you need to stabilize the count around going back to session restored stuff, so that we don't end up bouncing off zero for the subframes?

Comment 4

[Josh Matthews [:jdm]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/01259925085c

I added an assert to the function to be safe, but I think the counting should be ok.

Comment 5

[Josh Matthews [:jdm]]

Backed out https://hg.mozilla.org/integration/mozilla-inbound/rev/d6b8a8bedb49.

Comment 6

[Josh Matthews [:jdm]]

Attachment: Add observer notification for last PB docshell going away.

Comment 7

[(no longer active)]

Can this land, Josh?

Comment 8

[Josh Matthews [:jdm]]

Yes, I just haven't got around to it.

Comment 9

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9065e98ffb5d

Comment 10

[(no longer active)]

Attachment: Test case

Comment 11

[Josh Matthews [:jdm]]

I don't think the whole window close + gc dance should be necessary; this is meant to fire after the last docshell leaves private mode. Why doesn't setting the privateWindow flag to false trigger it?

Comment 12

[(no longer active)]

Because the value is decremented when the docshell gets destroyed, and that happens only when a CC is run after the window has been closed.

Do you have any better suggestions?

Comment 13

[Josh Matthews [:jdm]]

Comment on attachment 611548 [details] [diff] [review]
Test case

It makes me sad that this is necessary, but ok.

Comment 14

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/9065e98ffb5d

leaving open for the test

Comment 15

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ccb232b6b97a

Comment 16

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/ccb232b6b97a