725380 - CrashReporter can call doFinish twice

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Followup from bug 723495

We should be returning if the spec is null here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/CrashReporter.java.in#245

Without that we could call doFinish() twice, since the try block will silence the exception and call the doFinish() at the bottom of the function.

This patch adds the return and ports the changes to the XUL version too.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/50cc461ad671

Comment 2

[Ed Morley [:emorley]]

Backed out of inbound for xul build failure:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=ee360a77bfc9

https://hg.mozilla.org/integration/mozilla-inbound/rev/06f65b4e6c81

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

relanded with a XUL fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/538479680915

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/538479680915

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 595433 [details] [diff] [review]
patch

[Approval Request Comment]
Fixes a crash

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 595433 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 7

[Matt Brubeck (:mbrubeck)]

Comment on attachment 595433 [details] [diff] [review]
patch

Clearing approval for Aurora 12 and Beta 11 because we are not currently planning a Native Fennec release of these versions.  If this changes in the future, we will likely do a mass uplift of all native fennec changes.  For now, let's get these bugs off the channel triage radar.

[Filter on the string "mbrubeck-bugspam" if you want to delete all of these emails at once.]