725517 - Error during configure after bug 683127: "line 25335: test: too many arguments"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ed Morley [:emorley]]

Win7 x64 (32bit build)
MozillaBuild 1.6
https://hg.mozilla.org/integration/mozilla-inbound/rev/07da69ba7e52

{
c:/mozilla/inbound/configure: line 25335: test: too many arguments
...
c:/mozilla/inbound/configure: line 25441: test: too many arguments
}

Equates to:
http://mxr.mozilla.org/mozilla-central/source/configure.in#9066
> if test -n "$MOZ_LINKER" -a -z "$MOZ_OLD_LINKER" -a $ac_cv_func_dladdr = no ; then

and...
http://mxr.mozilla.org/mozilla-central/source/configure.in#9073
> if test -n "$MOZ_LINKER" -a -z "$MOZ_OLD_LINKER" -a $ac_cv_func_dladdr = no; then

Added by bug 683127.

Build carries on regardless, perhaps another argument for adding |set -o errexit| to configure (albeit it will require a number of other changes, along the lines of bug 698545 comment 1).

Comment 1

[Mike Hommey [:glandium]]

Does quoting "$ac_cv_func_dladdr" solve the issue?

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

> Does quoting "$ac_cv_func_dladdr" solve the issue?

Yup :-)

Comment 3

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/?tree=Try&rev=138e2820a551

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/40c94c17b303

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/40c94c17b303