725723 - rename reftests/flexbox/ to reftests/box

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

The directory /layout/reftests/flexbox/ currently contains 4 tests for -moz-box.

I'd like to rename this to reftests/box/ because:
 - it's for "display: [-vendor-]box", as compared to "display: [-vendor-]flexbox"
 - we already have 2 other directories of -moz-box related tests in "box"-themed folders:
     reftests/box-ordinal/
     reftests/box-properties/

and of course we're going to need a place to put "display: [-vendor-]flexbox" tests, and I'd like that to be in reftests/flexbox.  (In my local patches, I've been sticking them in reftests/css-flexbox, but IMHO it'd be madness to have both "flexbox" and "css-flexbox" reftest directories.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: patch ("hg mv flexbox box" & update reftest.list)

Here's the patch for the rename. It's just a hg mv plus an update to reftest.list.

(I used the newer (I think?) commenting convention from that reftest.list file, with a slightly more descriptive comment than just the quoted directory name)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 595812 [details] [diff] [review]
patch ("hg mv flexbox box" & update reftest.list)

r=dbaron

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6711ced03ad3

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/6711ced03ad3