725923 - backport bug 663835 to bmo (extend test scripts to include extensions)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[:glob ✱]

i thought this was backported, but evidently not.  i keep on getting caught by unfiltered directives.

Comment 1

[David Lawrence [:dkl]]

never backported to 4.0 but it is bmo/4.2 where I have been fixing all of the errors as they pop up.

Didn't want to backport it to 4.0 due to all of the fixes required and figured better to get a fresh start in 4.2.

dkl

Comment 2

[:glob ✱]

Attachment: patch v1

here's the patch.

the bulk of this change is adding FILTERs and terms, so it should be low risk.

there's 3 things there which aren't filter/terms changes:
  - i added json as a valid filter to 008filters.t (for the bzapi ext)
  - i edited bug/create/user-message.html.tmpl to remove stuff which hasn't
    been visible for a while now
  - i renamed a variable in splinter from configBugzillaUrl to configBzUrl
    because this was way easier than fixing the test

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 595974 [details] [diff] [review]
patch v1

Review of attachment 595974 [details] [diff] [review]:
-----------------------------------------------------------------

They all look good to me from a quick inspection and they generate a clean rest run. r=dkl

Only issue was the patch failure since user_activity.html.tmpl is already fixed in the tree. You
can ignore this error or commit.

patching file extensions/BMO/template/en/default/pages/user_activity.html.tmpl
Hunk #1 FAILED at 108.
Hunk #2 FAILED at 131.
2 out of 2 hunks FAILED -- saving rejects to file extensions/BMO/template/en/default/pages/user_activity.html.tmpl.rej

Comment 4

[:glob ✱]

thanks dkl :)

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified extensions/BMO/template/en/default/account/create.html.tmpl
modified extensions/BMO/template/en/default/bug/create/create-brownbag.html.tmpl
modified extensions/BMO/template/en/default/bug/create/create-itrequest.html.tmpl
modified extensions/BMO/template/en/default/bug/create/create-legal.html.tmpl
modified extensions/BMO/template/en/default/bug/create/create-mozlist.html.tmpl
modified extensions/BMO/template/en/default/bug/create/create-mozpr.html.tmpl
modified extensions/BMO/template/en/default/bug/create/create-swag.html.tmpl
modified extensions/BMO/template/en/default/bug/create/create-winqual.html.tmpl
modified extensions/BMO/template/en/default/bug/create/user-message.html.tmpl
modified extensions/BMO/template/en/default/global/choose-product.html.tmpl
modified extensions/BMO/template/en/default/hook/bug/create/create-guided-form.html.tmpl
modified extensions/BMO/template/en/default/hook/global/header-additional_header.html.tmpl
modified extensions/BMO/template/en/default/hook/global/messages-messages.html.tmpl
modified extensions/BMO/template/en/default/hook/global/user-error.html.tmpl/auth_failure/permissions.html.tmpl
modified extensions/BMO/template/en/default/list/list.microsummary.tmpl
modified extensions/BMO/template/en/default/list/server-push.html.tmpl
modified extensions/BMO/template/en/default/pages/etiquette.html.tmpl
modified extensions/BMO/template/en/default/pages/release_tracking_report.html.tmpl
modified extensions/BMO/template/en/default/pages/triage_reports.html.tmpl
modified extensions/BzAPI/template/en/default/config.json.tmpl
modified extensions/ComponentWatching/template/en/default/account/prefs/component_watch.html.tmpl
modified extensions/GuidedBugEntry/template/en/default/guided/guided.html.tmpl
modified extensions/REMO/template/en/default/bug/create/create-mozreps.html.tmpl
modified extensions/REMO/template/en/default/bug/create/created-mozreps.html.tmpl
modified extensions/SecureMail/template/en/default/account/prefs/securemail.html.tmpl
modified extensions/SecureMail/template/en/default/pages/securemail/help.html.tmpl
modified extensions/Splinter/template/en/default/pages/splinter.html.tmpl
modified extensions/Splinter/template/en/default/pages/splinter/help.html.tmpl
modified extensions/Splinter/web/splinter.js
modified extensions/TagNewUsers/template/en/default/hook/bug/comments-user.html.tmpl
modified t/004template.t
modified t/008filter.t
modified t/Support/Templates.pm
Committed revision 8064.

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/BMO/Extension.pm
modified extensions/BMO/template/en/default/bug/create/user-message.html.tmpl
modified extensions/BMO/template/en/default/pages/etiquette.html.tmpl
modified extensions/BMO/template/en/default/pages/user_activity.html.tmpl
modified extensions/BMO/web/js/sorttable.js
modified extensions/BMO/web/js/swag.js
modified extensions/ComponentWatching/template/en/default/account/prefs/component_watch.html.tmpl
modified extensions/GuidedBugEntry/template/en/default/guided/guided.html.tmpl
modified extensions/GuidedBugEntry/web/js/guided.js
modified extensions/REMO/web/js/swag.js
modified extensions/Splinter/template/en/default/pages/splinter.html.tmpl
modified extensions/Splinter/template/en/default/pages/splinter/help.html.tmpl
modified skins/custom/global.css
modified skins/custom/show_bug.css
modified template/en/default/bug/show-header.html.tmpl
Committed revision 8052.