726335 - Use NDEF Push with NFC (Android Beam | API level 14) for transferring currently focused tab

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Aaron Train [:aaronmt]]

Make use of the available NFDEF Push with NFC (Android Beam, API level 14) to transfer the currently focused tab from phone to phone.

* http://developer.android.com/sdk/android-4.0.html
* http://developer.android.com/reference/android/nfc/NdefMessage.html
* http://developer.android.com/resources/samples/AndroidBeamDemo/src/com/example/android/beam/Beam.html
* http://developer.android.com/guide/topics/nfc/nfc.html

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Not in the 1.0 scope.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Cosmetic cleanup

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Receive URIs over NFC

We probably want to defer this until we do a permission batch upgrade.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 720762 [details] [diff] [review]
Receive URIs over NFC


>+                <action android:name="android.nfc.action.NDEF_DISCOVERED"/>
>+                <category android:name="android.intent.category.DEFAULT" />
>+                <data android:scheme="http" />
>+                <data android:scheme="https" />

I suppose we don't need to worry about ftp or any other protocols

>-        } else if (Intent.ACTION_VIEW.equals(action)) {
>+        } else if (Intent.ACTION_VIEW.equals(action)
>+            || (Build.VERSION.SDK_INT >= Build.VERSION_CODES.GINGERBREAD_MR1
>+                && NfcAdapter.ACTION_NDEF_DISCOVERED.equals(action))) {

I cringe a little at the increased complexity of the "if" test. I'd almost be OK with treating it as a separate condition, even though the 2 lines of code would be duped.

As it stands right now, we'll need to comment this out when it hits Beta. There is a wiki page for managing that process:
https://wiki.mozilla.org/Release_Management/Merge_Documentation

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Actually, should most of this onNewIntent stuff be moved to BrowserApp.java instead? I assume we don't want to be doing this in web apps, right?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)
> Actually, should most of this onNewIntent stuff be moved to BrowserApp.java
> instead? I assume we don't want to be doing this in web apps, right?

That's a better idea.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Ah, the intents don't get triggered on web apps anyway because the manifest entries are in the "App" activity, so it's not technically a problem, but I moved it over anyway for less confusion.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Receive URIs over NFC (v2)

Updated, carrying r+

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Receive URIs over NFC (v3)

Updated to use "10" instead of the version code name to be consistent with the rest of BrowserApp.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: Allow sending current tab over Beam

Comment 11

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9fa7600200f
https://hg.mozilla.org/integration/mozilla-inbound/rev/a38ff8b11dc0
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d6d7796e284

I filed bug 847898 for the disable/backout and updated the wiki page at https://wiki.mozilla.org/Release_Management/Merge_Documentation#Known_Backouts_for_Version with the bug number. Not sure if anything else needs to be done here right now.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b9fa7600200f
https://hg.mozilla.org/mozilla-central/rev/a38ff8b11dc0
https://hg.mozilla.org/mozilla-central/rev/9d6d7796e284

Comment 13

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

There have been some very interesting flaws shown at security conferences regarding NFC, marking this for sec-review after the fact.

Comment 14

[Alex Keybl [:akeybl]]

We won't note given bug 847898. We'll note once the feature is more ready for release.

Comment 15

[Alex Keybl [:akeybl]]

Adding the feature keyword to be included in the new Release Tracking page.