Closed
Bug 726503
Opened 12 years ago
Closed 12 years ago
FILE_FLAG_SEQUENTIAL_SCAN always being passed for all file IO
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: bbondy, Assigned: bbondy)
References
Details
Attachments
(1 file)
|
852 bytes,
patch
|
taras.mozilla
:
review+
|
Details | Diff | Splinter Review |
We're currently always passing the read-ahead flag (FILE_FLAG_SEQUENTIAL_SCAN) on Windows for every file operation. This flag causes 1) old pages to be released faster and 2) extra data to be read before it is needed (if it is needed). This is good in a lot of cases, but we should only use it when it is needed and when the flag is actually set. I think it was unintentionally always turned on in October of 2011 in Bug 686691.
Attachment #596552 -
Flags: review?(benjamin)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 596552 [details] [diff] [review] Patch v1. Good catch
Attachment #596552 -
Flags: review?(benjamin) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/4e0b3a431e2e
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4e0b3a431e2e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•