726507 - HTML and XUL accessible classes shouldn't use nsAccessibilityService::GetAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

search through html and xul folders (http://mxr.mozilla.org/mozilla-central/source/accessible/src/) for GetAccService()->GetAccessible( and replace all calls on mDoc->GetAccessible(

Comment 1

[joseph]

Attachment: First version of patch.

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 596950 [details] [diff] [review]
First version of patch.

Review of attachment 596950 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/html/nsHTMLSelectAccessible.cpp
@@ +436,5 @@
>      content = content->GetParent();
>    }
>  
>    if (content) {
> +    nsAccessible* selAcc = mDoc->GetAccessible(content, nsnull);

nsDocAccessible doesn't take two arguments

Comment 3

[joseph]

Attachment: Patch - Second version

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 596994 [details] [diff] [review]
Patch - Second version

Review of attachment 596994 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 5

[alexander :surkov (:asurkov)]

inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/785130198c91

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/785130198c91