Closed
Bug 726634
Opened 12 years ago
Closed 12 years ago
Fix the maximum nodes limitation in Tilt
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 13
People
(Reporter: vporof, Assigned: vporof)
References
Details
(Whiteboard: [tilt])
Attachments
(1 file)
13.64 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
If a webpage has more than ~5000 nodes, it will be chopped off in Tilt, in a quite ugly fashion. This shouldn't happen.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Assignee | ||
Updated•12 years ago
|
Whiteboard: [tilt]
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #597058 -
Flags: review?(rcampbell)
Assignee | ||
Comment 2•12 years ago
|
||
Try: https://tbpl.mozilla.org/?tree=Try&rev=47af48d6e93e
Comment 3•12 years ago
|
||
Comment on attachment 597058 [details] [diff] [review] v1 +// index buffer of 12 unsigned int elements, obviously one for each vertex; "obviously" +// if a webpage has enough nodes to overflow the index buffer elements size, +const MAX_GROUP_NODES = Math.pow(2, Uint16Array.BYTES_PER_ELEMENT * 8) / 12 - 1; when does a Uint16Array have something other than 2 bytes per element? This feels like we could hardcode the value. Also, this returns a non-integer value of 5460.333333333333. That seems... imprecise. + for (let i = 0, len = mesh.length; i < len; i++) { presumably, the number of mesh groups is going to be 1 in most cases? I'm gonna shelf this until my brain can process the rest of it.
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Rob Campbell [:rc] (robcee) from comment #3) > Comment on attachment 597058 [details] [diff] [review] > v1 > > +const MAX_GROUP_NODES = Math.pow(2, Uint16Array.BYTES_PER_ELEMENT * 8) / 12 > - 1; > > when does a Uint16Array have something other than 2 bytes per element? This > feels like we could hardcode the value. > I don't know.. on quantum computers? On Darth Vader's helmet? :) Why hardcode the value if there's a logical formula to get it? > Also, this returns a non-integer value of 5460.333333333333. That seems... > imprecise. > Doesn't affect anything. I can parseInt if you wish. > + for (let i = 0, len = mesh.length; i < len; i++) { > > presumably, the number of mesh groups is going to be 1 in most cases? > Yup.
Comment 5•12 years ago
|
||
(In reply to Victor Porof from comment #4) > (In reply to Rob Campbell [:rc] (robcee) from comment #3) > > Comment on attachment 597058 [details] [diff] [review] > > v1 > > > > +const MAX_GROUP_NODES = Math.pow(2, Uint16Array.BYTES_PER_ELEMENT * 8) / 12 > > - 1; > > > > when does a Uint16Array have something other than 2 bytes per element? This > > feels like we could hardcode the value. > > > > I don't know.. on quantum computers? On Darth Vader's helmet? :) lol, imo. > Why hardcode the value if there's a logical formula to get it? Ok, fair enough. > > Also, this returns a non-integer value of 5460.333333333333. That seems... > > imprecise. > > > > Doesn't affect anything. I can parseInt if you wish. maybe a Math.floor()? > > + for (let i = 0, len = mesh.length; i < len; i++) { > > > > presumably, the number of mesh groups is going to be 1 in most cases? > > Yup. OK.
Updated•12 years ago
|
Attachment #597058 -
Flags: review?(rcampbell) → review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [tilt] → [tilt][land-in-fx-team]
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/80e183c9caff
Whiteboard: [tilt][land-in-fx-team] → [tilt][fixed-in-fx-team]
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/80e183c9caff
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [tilt][fixed-in-fx-team] → [tilt]
Target Milestone: --- → Firefox 13
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•