Closed
Bug 726794
Opened 12 years ago
Closed 12 years ago
Nonexistent macro WTF_PLATFORM_LINUX used in MacroAssemblerARM.cpp instead of WTF_OS_LINUX
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: philip, Assigned: dmandelin)
Details
Attachments
(1 file)
|
1.45 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Bug 625600 renamed WTF_PLATFORM_LINUX to WTF_OS_LINUX, but js/src/assembler/assembler/MacroAssemblerARM.cpp still uses WTF_PLATFORM_LINUX in isVFPPresent() for checking /proc/self/auxv, so that code will never get built. js/src/assembler/wtf/Assertions.h also seems to use some macros that were renamed (WTF_PLATFORM_SYMBIAN, WTF_PLATFORM_WIN_OS) but I have no idea whether that matters at all.
|
Assignee | |
Comment 1•12 years ago
|
||
Thanks for the catch.
Assignee: general → dmandelin
Attachment #606700 -
Flags: review?(dvander)
|
||
Updated•12 years ago
|
Attachment #606700 -
Flags: review?(dvander) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Wow, fast review! :-D I'm running it on try for build bustage paranoia.
|
|
Assignee | |
Comment 3•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/7a7f8fbd62d8
Target Milestone: --- → mozilla14
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7a7f8fbd62d8
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•