726951 - <canvas> clip with shadowBlur, has vertical offset

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[david berneda]

Attachment: canvas_clip_shadow.htm

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/535.7 (KHTML, like Gecko) Chrome/16.0.912.77 Safari/535.7

Steps to reproduce:

Applying a rectangular clip, then drawing content with shadowblur over the clipped rectangle.  See attachment, click the "Clip" checkbox.


Actual results:

The clipped rectangle seems to be vertically offset by a value aprox twice the shadowOffsetY.


Expected results:

Clipped rectangle should respect shadow parameters. When no shadow is applied, clipping works fine.

Comment 1

[Alice0775 White]

Confirmed on
http://hg.mozilla.org/mozilla-central/rev/60edf587f4af
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0a1) Gecko/20120214 Firefox/13.0a1 ID:20120214031227

This does not happens on ubuntu
http://hg.mozilla.org/mozilla-central/rev/60edf587f4af
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0a1) Gecko/20120214 Firefox/13.0a1 ID:20120214031227

Regression window(cached m-c)
Works:
http://hg.mozilla.org/mozilla-central/rev/2b9a669880df
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110713 Firefox/8.0a1 ID:20110713140256
Fails:
http://hg.mozilla.org/mozilla-central/rev/4162bda16a6a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110713 Firefox/8.0a1 ID:20110713142700
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2b9a669880df&tochange=4162bda16a6a


Regression window(cached m-i)
Works:
http://hg.mozilla.org/integration/mozilla-inbound/rev/0f18324ce229
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110712 Firefox/8.0a1 ID:20110712150650
Fails:
http://hg.mozilla.org/integration/mozilla-inbound/rev/e703f4342489
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110713 Firefox/8.0a1 ID:20110713010015
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0f18324ce229&tochange=e703f43
42489

Suspected: Bug 666452

Comment 2

[Bas Schouten (:bas.schouten)]

Attachment: Correctly use height to normalize v texture coordinate.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Reftest please

Comment 4

[Bas Schouten (:bas.schouten)]

Attachment: Test for shadow clips working correctly on non-rectangular canvases

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 597282 [details] [diff] [review]
Test for shadow clips working correctly on non-rectangular canvases

A better test name like 726951-shadow-clips.html would be nice

Comment 6

[Bas Schouten (:bas.schouten)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/274121fbd839
https://hg.mozilla.org/integration/mozilla-inbound/rev/161ce815ab79

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/274121fbd839
https://hg.mozilla.org/mozilla-central/rev/161ce815ab79

Comment 8

[Alex Keybl [:akeybl]]

This is a regression from FF8 (according to comment#1), and we have zero dupes, so I don't think this needs to be tracked for FF10 and up. Please nominate for Aurora/Beta approval if you disagree and feel there's ample reason to uplift.

Comment 9

[Bas Schouten (:bas.schouten)]

(In reply to Alex Keybl [:akeybl] from comment #8)
> This is a regression from FF8 (according to comment#1), and we have zero
> dupes, so I don't think this needs to be tracked for FF10 and up. Please
> nominate for Aurora/Beta approval if you disagree and feel there's ample
> reason to uplift.

I don't really mind either way, the only reason to uplift this might be that it's -extremely- low-risk.