726975 - Tidy up browser/app/Makefile.in and skip a shell execution

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

This patch does several things:

- Replaces the shell execution for APP_VERSION with a simple use of MOZ_APP_VERSION
- Groups DEFINES that aren't flag dependent in one section
- Tidies up the LOCAL_INCLUDES into one block rather than separate lines
- Removes the -DDEBUG flag to the splash.rc files, I couldn't see it being used anywhere.
- Removes the forced-copying (rather than symlink) of mangle and shlibsign for Mac bundles. We never use mangle, and shlibsign is used outside of the directory, but seems to work as a symlink anyway.

Comment 1

[Mozilla RelEng Bot]

Try run for a91c6c033980 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a91c6c033980
Results (out of 28 total builds):
    success: 26
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-a91c6c033980

Comment 2

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/428ba14f09b6

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/428ba14f09b6