727145 - Pass -Wno-return-type-c-linkage to clang

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Pass -Wno-return-type-c-linkage to clang

I am normally in favour of fixing warnings by changing the code or changing the compiler, but  clang's return-type-c-linkage is the complete oposite of what we do with jsval, so it is probably better to just disable it.

Comment 1

[Gregory Szorc [:gps]]

I ran into this today on Linux using a build pulled after r150418.

Looks like an unwanted change to build/macosx/common snuck into the patch up for review.

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Pass -Wno-return-type-c-linkage to clang

now without the bits in build/macosx/common.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2046a1f46d40

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2046a1f46d40

Comment 5

[:Irving Reid (No longer working on Firefox)]

This change causes Xcode 4.0.2 (Mac OS X 10.6) to print many

warning: unknown warning option '-Wno-return-type-c-linkage' [-Wunknown-warning-option]


ireid% clang --version
Apple clang version 2.0 (tags/Apple/clang-139) (based on LLVM 2.9svn)
Target: x86_64-apple-darwin10
Thread model: posix

Comment 6

[Gregory Szorc [:gps]]

(In reply to Irving Reid (:irving) from comment #5)
> This change causes Xcode 4.0.2 (Mac OS X 10.6) to print many
> 
> warning: unknown warning option '-Wno-return-type-c-linkage'
> [-Wunknown-warning-option]

That's because Clang added the new warning only a few weeks ago in the not-yet-released 3.1 release.

Perhaps we could add -Wno-unknown-warning-option to the default Clang compiler flags...