Closed
Bug 727156
Opened 12 years ago
Closed 12 years ago
fix warnings in toolkit/mozapps/update/
Categories
(Toolkit :: Application Update, defect)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla12
Tracking | Status | |
---|---|---|
firefox11 | --- | unaffected |
firefox12 | --- | fixed |
firefox13 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 2 obsolete files)
4.33 KB,
patch
|
bbondy
:
review+
|
Details | Diff | Splinter Review |
There's a couple different warnings here: * set-but-unused variables * unused functions (!) * const char * -> char * warnings Let's go ahead and fix them all in one go.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #597089 -
Flags: review?(netzen)
Comment 2•12 years ago
|
||
Comment on attachment 597089 [details] [diff] [review] patch Review of attachment 597089 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch. But we need to tweak the ifdefs instead of removing those functions. ::: toolkit/mozapps/update/updater/updater.cpp @@ -1461,5 @@ > - * @return true if the information was retrieved and it is pending > - * or pending-service. > -*/ > -static bool > -IsUpdateStatusPending(bool &isPendingService) This is needed when #ifdef MOZ_MAINTENANCE_SERVICE (which happens currently on windows x86) @@ -1495,5 @@ > - * is set to succeeded or not. > - * @return true if the information was retrieved and it is succeeded. > -*/ > -static bool > -IsUpdateStatusSucceeded(bool &isSucceeded) This is needed on Windows so when #ifdef XP_WIN.
Attachment #597089 -
Flags: review?(netzen) → review-
Assignee | ||
Comment 3•12 years ago
|
||
Thanks for the pointers. That's the fun of fixing compiler warnings, isn't it?
Attachment #597089 -
Attachment is obsolete: true
Attachment #597109 -
Flags: review?(netzen)
Comment 4•12 years ago
|
||
Comment on attachment 597109 [details] [diff] [review] patch Review of attachment 597109 [details] [diff] [review]: ----------------------------------------------------------------- One last pass pls :D Also pls run through try to make sure it builds fine on x64 and Windows x86. ::: toolkit/mozapps/update/updater/updater.cpp @@ +1522,2 @@ > > #ifdef XP_WIN The previous #ifdef XP_WIN can be combined with this one.
Attachment #597109 -
Flags: review?(netzen)
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #597109 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Whiteboard: [autoland-try]
Updated•12 years ago
|
Whiteboard: [autoland-try] → [autoland-in-queue]
Comment 6•12 years ago
|
||
Autoland Patchset: Patches: 597113 Branch: mozilla-central => try Destination: http://hg.mozilla.org/try/pushloghtml?changeset=b19c8e48aeaf Try run started, revision b19c8e48aeaf. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=b19c8e48aeaf
Comment 7•12 years ago
|
||
Comment on attachment 597113 [details] [diff] [review] patch Review of attachment 597113 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for cleaning this up, you're good to go as long as it passes try.
Attachment #597113 -
Flags: review+
Comment 8•12 years ago
|
||
Try run for b19c8e48aeaf is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=b19c8e48aeaf Results (out of 210 total builds): success: 177 warnings: 19 failure: 14 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-b19c8e48aeaf
Updated•12 years ago
|
Whiteboard: [autoland-in-queue]
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 9•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/a8634484e86b
Keywords: checkin-needed
Target Milestone: --- → mozilla13
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a8634484e86b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Blocks: buildwarning
Comment 11•12 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/18840d884c97
status-firefox11:
--- → unaffected
status-firefox12:
--- → fixed
status-firefox13:
--- → fixed
Target Milestone: mozilla13 → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•