727497 - Don't call CreateSurfaceForWindow in MakeCurrent in EGL

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

I don't think it make sense to call CreateSurface in EGL. We're not ready to provide a surface in all cases, in particular shutdown in Maple.

I suggest that we bind a context with a surface. This lets shutdown continue without deadlocking/crashing.

I plan on also landing this fix on m-c to reduce the merge diff.

Comment 1

[Ali Juma [:ajuma]]

Comment on attachment 597456 [details] [diff] [review]
patch

Review of attachment 597456 [details] [diff] [review]:
-----------------------------------------------------------------

I'd add a comment that we're doing this to allow cleanup to proceed (as opposed to just bailing and returning false when we don't have a surface).

Comment 2

[Benoit Girard (:BenWa)]

Attachment: patch + comment

Comment 3

[Ali Juma [:ajuma]]

Comment on attachment 597514 [details] [diff] [review]
patch + comment

Review of attachment 597514 [details] [diff] [review]:
-----------------------------------------------------------------

"bind the surface" -> "bind NO_SURFACE"
"wont" -> "won't"

Comment 4

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/projects/maple/rev/488385db5539

Comment 5

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4988f2f80c44

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4988f2f80c44