727951 - removing expired news articles broken

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[David :Bienvenu]

Attachment: proposed fix

the url we run to get rid of expired articles is failing. Patch upcoming

Comment 1

[Joshua Cranmer [:jcranmer]]

I'd feel a lot better about this if we could test it.

Comment 2

[Joshua Cranmer [:jcranmer]]

I don't think this is quite enough--I tested it briefly (by accident, natch) and the result I got appears to be that it cleared the newsgroup but it also opened up the file dialog "do you want to open the file mozilla.dev.test.multimedia?"...

Comment 3

[David :Bienvenu]

(In reply to Joshua Cranmer [:jcranmer] from comment #2)
> I don't think this is quite enough--I tested it briefly (by accident, natch)
> and the result I got appears to be that it cleared the newsgroup but it also
> opened up the file dialog "do you want to open the file
> mozilla.dev.test.multimedia?"...

Did you try it with the patch in bug 492329 ? That's the only way I've tried it, and I did not get the file dialog.

Comment 4

[Joshua Cranmer [:jcranmer]]

Comment on attachment 597934 [details] [diff] [review]
proposed fix

I finally did a more purposeful test of this, and it worked this time. The UI for clearing messages kind of sucks (you see no apparent visual cue that anything is happening until the operation finishes, when messages disappear), but that's probably worth another bug.

Some other notes:
1. Lose the comment (or at least the "I think")
2. return rv; probably ought to be return NS_OK;
3. It's probably cleaner to separate the if statement from the rest of the code with blank lines.

Comment 5

[David :Bienvenu]

fixed on trunk - forgot to address the comments; I'll do that later today

Comment 6

[David :Bienvenu]

http://hg.mozilla.org/comm-central/rev/c7d25333f38a pushed for review comments.