Closed
Bug 728350
Opened 12 years ago
Closed 12 years ago
Updated Telemetry help->about message to match notification message
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 14
People
(Reporter: lmandel, Assigned: theo)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Telemetry])
Attachments
(2 files, 2 obsolete files)
231.87 KB,
image/jpeg
|
Details | |
3.45 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
Telemetry currently has an opt-in notification in product. An opt-out notification for Nightly and Aurora users is being added in bug 725407. Telemetry also has text in the help->about dialog (bug 701182). The message for the two notifications matches in terms of detail. The messages are: opt-in "Will you help improve %1$S by sending anonymous information about performance, hardware characteristics, feature usage, and browser customizations to %2$S?" opt-out "$PRODUCTNAME sends information about performance, hardware, usage and customizations back to Mozilla to help improve Firefox." The Telemetry help->about message should match the messages that we use in our notification messages. Specifically, I would like to see the about dialogs updated to use the following text: It automatically sends information about performance, hardware, usage and customizations back to &vendorShortName; to help make &brandShortName; better.
Assignee | ||
Comment 1•12 years ago
|
||
Okay, I'm on it :) Should I update message on mobile as well? (bug 702284)
Reporter | ||
Comment 2•12 years ago
|
||
Yes. For now let's use the same message on mobile. We may revisit the mobile message after we come up with the appropriate notification message for mobile in bug 728340.
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #598346 -
Flags: review?(lmandel)
Reporter | ||
Comment 4•12 years ago
|
||
Comment on attachment 598346 [details] [diff] [review] Patch V1 Review of attachment 598346 [details] [diff] [review]: ----------------------------------------------------------------- This is the change I would like. Can you confirm with a screenshot that the extra text hasn't affected the overall appearance of the about dialog?
Attachment #598346 -
Flags: review?(lmandel) → review+
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Lawrence Mandel [:lmandel] from comment #4) > Comment on attachment 598346 [details] [diff] [review] > Patch V1 > > Review of attachment 598346 [details] [diff] [review]: > ----------------------------------------------------------------- > > This is the change I would like. Can you confirm with a screenshot that the > extra text hasn't affected the overall appearance of the about dialog? Thanks Lawrence. I anticipated this, the build is being compiled. :)
Comment 6•12 years ago
|
||
Comment on attachment 598346 [details] [diff] [review] Patch V1 You'll need to change the entity name here (warningDesc.telemetryDesc?), since the string is semantically different, and that's the only way we have of notifying localizers of such changes.
Attachment #598346 -
Flags: review+ → feedback+
Assignee | ||
Comment 7•12 years ago
|
||
Attachment #598346 -
Attachment is obsolete: true
Assignee | ||
Comment 8•12 years ago
|
||
Bug for the background issue is bug 712636.
Attachment #598381 -
Flags: review?(gavin.sharp)
Comment 9•12 years ago
|
||
Comment on attachment 598381 [details] [diff] [review] PatchV2 You'll also need to change the reference to the entity in the LOCALIZATION NOTE. r=me with that.
Attachment #598381 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 10•12 years ago
|
||
Attachment #598384 -
Flags: review?(gavin.sharp)
Updated•12 years ago
|
Attachment #598381 -
Attachment is obsolete: true
Updated•12 years ago
|
Attachment #598384 -
Flags: review?(gavin.sharp) → review+
Updated•12 years ago
|
Assignee: nobody → theo.chevalier11
Reporter | ||
Comment 11•12 years ago
|
||
This looks ready to land. Can someone please push to Mozilla inbound?
Assignee | ||
Updated•12 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [Telemetry] → [Telemetry][checkin-needed]
Version: 10 Branch → unspecified
Comment 12•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d2525447715
Target Milestone: --- → Firefox 14
Updated•12 years ago
|
Whiteboard: [Telemetry][checkin-needed] → [Telemetry]
Comment 13•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2d2525447715
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•