728396 - Flash of old-style login form when BrowserID available

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect)

Description

[Les Orchard [:lorchard]]

Here's the issue:

* Attempt to login via /users/login
* Sometimes, the old-style login form will appear and remain for awhile
* Start to fill out the old-style form...
* At some point, the BrowserID blurb and button will suddenly replace the old-style form

I suspect this is part of the AJAXification process we did to the Sign In button in bug 721171. But, it feels like a confusing & jarring experience, especially if the AJAX request takes awhile for whatever reason. 

FWIW, there's been at least one mention / complaint about this in #identity as a BrowserID issue that's actually an MDN issue.

Comment 1

[Les Orchard [:lorchard]]

I'd suggest we don't progressively enhance from old-login to BrowserID on this page, especially not if it waits on the completion of an HTTP request in AJAX. 

I'd say show the BrowserID blurb for enabled locales and show a loading spinner until the form has loaded. Showing and replacing the old-style login just seems like we're giving it and then taking it away, which was frustrating.

Comment 2

[Luke Crouch [:groovecoder]]

Someday I'm going to write up a MDN BrowserID summary of all the issues we've addressed/fixed in subsequent sprints after our initial launch of BrowserID.

Comment 3

[Luke Crouch [:groovecoder]]

Only show sign-in button after it's wired.

Comment 4

[raymond [:retornam] (inactive)]

qa-verified-stage https://developer-stage9.mozilla.org/en-US/users/login

Comment 5

[raymond [:retornam] (inactive)]

verified fixed https://developer.mozilla.org/en-US/users/login