728662 - Error: document.getElementById("sep-window-list") is null

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Nomis101]

In the error console in Thunderbird 11 I see:

Error: document.getElementById("sep-window-list") is null
Source File: chrome://messenger/content/hiddenWindow.js
Line: 46

Comment 1

[:aceman]

I think I have seen this somewhere. Can you tell what you were doing when the error comes up? Does it happen in TB13?

Comment 2

[Nomis101]

(In reply to :aceman from comment #1)
> Can you tell what you were doing when
> the error comes up? 
Nothing specific, I have this everytime. If you want some STR, than: Start Thunderbird --> Open the error console

(In reply to :aceman from comment #1)
> Does it happen in TB13?
Yes, I also see it in the latest nightly.

Comment 3

[:aceman]

I still can't see it anywhere. Does it still happen? Have you tried Thunderbird's Safe mode?

Comment 4

[:aceman]

Try Help->Restart with addons disabled.

Comment 5

[:aceman]

Ok, that element seems to be defined only /mozilla/toolkit/content/macWindowMenu.inc and is being overlaid on Mac.

http://mxr.mozilla.org/comm-central/search?string=sep-window-list&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

At http://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/browser.js#1463 the attribute setting is dependent on being on Mac OS X.

In Seamonkey at http://mxr.mozilla.org/comm-central/source/suite/browser/navigator.js#1915 they set the attribute only if the element exists. So do the same in TB.

Comment 6

[:aceman]

Attachment: patch

So actually I should have seen the error on linux but I have not. Nomis101 filed it under Mac where I would expect the element to exist so no error should be produced. Strange. I'd like somebody with a Mac to check this out.

Comment 7

[Nomis101]

I have no problem with your patch, no new error or whatsoever. But, I have checked and I don't see the reported error anymore in TB 23 and higher.

Comment 8

[:aceman]

Comment on attachment 789178 [details] [diff] [review]
patch

Josiah, are you able to check this out on Mac?

Comment 9

[Josiah Bruner [:jsbruner]]

(In reply to :aceman from comment #8)
> Comment on attachment 789178 [details] [diff] [review]
> patch
> 
> Josiah, are you able to check this out on Mac?

I'm not seeing the error at all in the error console on OS X. So I can't really say if your patch it working.

Comment 10

[Josiah Bruner [:jsbruner]]

Comment on attachment 789178 [details] [diff] [review]
patch

Review of attachment 789178 [details] [diff] [review]:
-----------------------------------------------------------------

Clearing review flag until more info is given on how to reproduce the error (If even possible).

Comment 11

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 789178 [details] [diff] [review]
patch

Yeah, I can see how that happened.

The m-c version (at http://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/browser.js#1388 ) is wrapped in an "#ifdef XP_MACOSX" (at http://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/browser.js#1357 )

The rest of the cleanup is unnecessary, but seems harmless, so r=me.  ;)

Thanks,
Blake.

Comment 12

[:aceman]

Thanks!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/fa422ca68f08