729041 - Remove nsEditorParserObserver

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Henri Sivonen (:hsivonen)]

I don't know what nsEditorParserObserver is supposed to do but the HTML5 parser doesn't support notifying it.

Since failure to notify this observer hasn't been noticed as a problem in over a year, let's remove this mystery observer.

Comment 1

[[e-mail]]

It used to stop you editing frameset documents. The caller was rewritten 10 years ago but nobody noticed that the replacement code didn't use it...

Comment 2

[[e-mail]]

[Removal is probably build system changes only, no C++ knowledge needed.]

Comment 3

[Charles Chan]

Attachment: Bug 729041: Patch-1

Here's the patch file. There is no dependency on the the Makefile either, therefore, simply require the use of 'hg remove ...'

Comment 4

[Henri Sivonen (:hsivonen)]

Do you have mercurial push access? Should this be now treated as [checkin-needed]?

Comment 5

[Charles Chan]

Hello Henri, I do not have push access. Shall I set the [checkin-needed] flag as you  have stated above?

Comment 6

[Henri Sivonen (:hsivonen)]

(In reply to Charles Chan from comment #5)
> Hello Henri, I do not have push access. Shall I set the [checkin-needed]
> flag as you  have stated above?

Normally the next step would have been adding "checkin-needed" to the keyword field. However, knowing that you would have done it next, I went ahead and treated this bug as if it had been marked checkin-needed already.

That is, I landed the patch to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee2931fcb5ae

(I tweaked the commit message to include ". r=hsivonen." and changed the separator punctuation after the bug number to use the more common convention.)

Thank you.

(This bug will be marked FIXED once mozilla-inbound is merged into mozilla-central.)

Comment 7

[Charles Chan]

Thanks! Henri.

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/ee2931fcb5ae