Closed Bug 729091 Opened 12 years ago Closed 12 years ago

SMTPRecipientsRefused: {'': (553, '5.0.0 <>... User address required')}

Categories

(developer.mozilla.org Graveyard :: Wiki pages, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED WONTFIX

People

(Reporter: groovecoder, Assigned: groovecoder)

Details

(Whiteboard: u=user c=browserid p=1 2.4.5)

[Django] Error (EXTERNAL IP): /en-US/users/sendemailreminder

Traceback (most recent call last):

  File "/data/www/django/developer.mozilla.org/kuma/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/django/developer.mozilla.org/kuma/apps/users/views.py", line 347, in send_email_reminder
    send_reminder_email(user)

  File "/data/www/django/developer.mozilla.org/kuma/apps/users/utils.py", line 51, in send_reminder_email
    send_mail(subject, message, settings.DEFAULT_FROM_EMAIL, [send_to])

  File "/data/www/django/developer.mozilla.org/kuma/vendor/src/django/django/core/mail/__init__.py", line 61, in send_mail
    connection=connection).send()

  File "/data/www/django/developer.mozilla.org/kuma/vendor/src/django/django/core/mail/message.py", line 210, in send
    return self.get_connection(fail_silently).send_messages([self])

  File "/data/www/django/developer.mozilla.org/kuma/vendor/src/django/django/core/mail/backends/smtp.py", line 86, in send_messages
    sent = self._send(message)

  File "/data/www/django/developer.mozilla.org/kuma/vendor/src/django/django/core/mail/backends/smtp.py", line 104, in _send
    email_message.message().as_string())

  File "/usr/lib/python2.6/smtplib.py", line 709, in sendmail
    raise SMTPRecipientsRefused(senderrs)

SMTPRecipientsRefused: {'': (553, '5.0.0 <>... User address required')}
Whiteboard: u=user c=browserid p= → u=user c=browserid p=1
Whiteboard: u=user c=browserid p=1 → u=user c=browserid p=1 2.4.5
Assignee: nobody → lcrouch
There are approx. 580 usernames without email addresses? If one of these users tries to sign in with BrowserID, they get the browserid_register screen with:

1. New MDN member - pick username
2. Returning MDN member - username/password
3. Forgot your email - username

options.

If they use the Forgot your email form, it causes this server error. We can easily avoid the server error, but what, if anything, can we do in this case where the user apparently forgot their password AND they don't have an email address? Nothing? If so, do we want to keep getting these as server errors so we at least have a record? Or should we just 'pass' them in the code? Should we add some language to the "Reminder email sent" page?

"In very rare cases, we may not have an email address for your account. In that case, you must sign in with your password to recover your account and <a href="/users/change_email">add an email address.</a>"

?
(In reply to Luke Crouch [:groovecoder] from comment #1)

> If they use the Forgot your email form, it causes this server error. We can
> easily avoid the server error, but what, if anything, can we do in this case
> where the user apparently forgot their password AND they don't have an email
> address? Nothing?

If a user has both forgotten their password and has either an inaccessible or blank email address on their profile, there's nothing we can do. At least, not automatically. That's neither worse nor better than the pre-BrowserID scenario.

> If so, do we want to keep getting these as server errors
> so we at least have a record? Or should we just 'pass' them in the code?
> Should we add some language to the "Reminder email sent" page?

If we *really* want to handle these errors, it'll take manual admin intervention and judgement calls. That is:

* Have recovery emails for profiles with blank addresses get sent to admins (ie. us) 

* Rather than an "email was sent" confirmation message, offer an email address or feedback form to the user to request a manual review of the situation.

Then again, if there's only 580 (out of over 10000) usernames without email addresses... this might be a lot of effort for a very rare situation, which we can just handle case-by-case.
I agree. And even when we get these server errors, the only way we could pro-actively contact the affected users is to check their profile page for some other contact channel. :(

So let's resolve this WONTFIX unless/until more errors come in, and I'd suggest we just rely on bugs for the user to request a manual review of the situation.

If more errors come in, we'll look at sending the reminder emails to admins to review and resolve.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Status: RESOLVED → VERIFIED
Version: Kuma → unspecified
Component: Website → Landing pages
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.