729162 - Add per-docshell observer list for private browsing transitions

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Josh Matthews [:jdm]]

To ensure that a DOMStorage clears its cache if its owning window switches privacy modes, we need some kind of immediate notification.

Comment 1

[Josh Matthews [:jdm]]

Attachment: Add per-docshell privacy mode transition observers.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 599226 [details] [diff] [review]
Add per-docshell privacy mode transition observers.

Why is this going on nsILoadContext and not on the docshell?

Comment 3

[Boris Zbarsky [:bzbarsky]]

(And also, please use an observer array, so you don't have to make assumptions about the removal behavior, if any.)

Comment 4

[Josh Matthews [:jdm]]

Only because it seemed logical to group it with the attribute.(In reply to Boris Zbarsky (:bz) from comment #2)
> Comment on attachment 599226 [details] [diff] [review]
> Add per-docshell privacy mode transition observers.
> 
> Why is this going on nsILoadContext and not on the docshell?

Only because it seemed logical to group it with the attribute.

Comment 5

[Boris Zbarsky [:bzbarsky]]

I don't think we should do that.  If we're trying to observe on a particular window, the API should be one window or docshell, not on the load context...

Comment 6

[Josh Matthews [:jdm]]

Attachment: Add per-docshell privacy mode transition observers.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 599471 [details] [diff] [review]
Add per-docshell privacy mode transition observers.

>+++ b/docshell/base/nsDocShell.h
>+    nsTObserverArray<nsIWeakReference*> mPrivacyObservers;

I'm ... a little surprised that worked.  You're getting nsIWeakReference objects, putting this in the array, then dropping the only ref to them, which should by rights explode.

Please make this member nsTObserverArray<nsWeakPtr>.

>+++ b/docshell/base/nsIDocShell.idl

Rev the uuid.

>+++ b/docshell/base/nsIPrivacyTransitionObserver.idl
>\ No newline at end of file

Add one, please.

r=me with those issues fixed.  Please do NOT check in without fixing the ownership model bit!

Comment 8

[Josh Matthews [:jdm]]

Attachment: Add per-docshell privacy mode transition observers.

Comment 9

[(no longer active)]

https://hg.mozilla.org/projects/birch/rev/6e93febee902

Comment 10

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/6e93febee902