Closed
Bug 729261
Opened 12 years ago
Closed 12 years ago
PB transition sets the usePrivateBrowsing attribute too eagerly
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 13
People
(Reporter: jdm, Assigned: jdm)
References
Details
Attachments
(1 file)
|
3.01 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
We end up setting the attribute for all windows that exist before transitioning, rather than all windows that exist after the transition. This is unfortunate.
|
Assignee | |
Comment 1•12 years ago
|
||
Mea culpa.
|
|
Assignee | |
Updated•12 years ago
|
Attachment #599314 -
Flags: review?(ehsan)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 599314 [details] [diff] [review] Set private browsing attribute on windows that exist after transition into PB mode. Review of attachment 599314 [details] [diff] [review]: ----------------------------------------------------------------- Hehe, nice!
Attachment #599314 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [needs landing]
|
|
Assignee | |
Comment 3•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/4facf0c60bdd
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [needs landing]
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/15461fddfe45
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
You need to log in
before you can comment on or make changes to this bug.
Description
•