729346 - Allow public access (in C++) to loaded scripts of a Domain object

Status: RESOLVED FIXED

(Tamarin Graveyard :: Library, defect)

Description

[William Maddox]

Attachment: Provide public accessor for m_loadedScripts field.

Allow access to the table of loaded scripts for a Domain object.
Access provided at the C++ level, for the benefit of host-provided native libraries only.

Patch proposed by Xing Zhang <[e-mail]>.

Comment 1

[William Maddox]

I'd recommend renaming the accessor to Domain::getLoadedScripts(), following the nomenclature for the data member.

The patch is trivial, except for possible GC hygiene issues.  Asking Felix to take a look at it.

Comment 2

[Felix S. Klock II [:pnkfelix, :fklock]]

Looks fine with me.

Comment 3

[Felix S. Klock II [:pnkfelix, :fklock]]

(reassigning to Xing since I think he will be renaming the accessor.)

Comment 4

[xzhang]

Attachment: change the accessor name to getLoadedScripts

change the accessor name to getLoadedScripts according to previous review

Comment 5

[xzhang]

Name change is done, assign it to Felix for review.

Comment 6

[Felix S. Klock II [:pnkfelix, :fklock]]

(The diff wasn't in the appropriate format for patching tamarin-redux, but its a trivial patch so that did not hold me up from reviewing nor will it hold me up from landing it.)

Comment 7

[Felix S. Klock II [:pnkfelix, :fklock]]

((also there were tabs introduced by both patches.  I am not sure why I did not notice that earlier.  Again, easily fixed and I'll just do it before I land it.))

Comment 8

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: Provide public accessor for m_loadedScripts field (v3 final).

Comment 9

[Tamarin Bot]

changeset: 7212:98ddf7c038a8
user:      Xing Zhang <[e-mail]>
summary:   Bug 729346: Provide public accessor for m_loadedScripts field. (p=xzhang, r=wmaddox, fklockii).

http://hg.mozilla.org/tamarin-redux/rev/98ddf7c038a8