729388 - Fix installs_allowed_from message for marketplace in validator

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect, P3)

Description

[Kumar McMillan [:kumar]]

If you upload an app with a bad install manifest it says this:

Error: To be included on https://apps-preview.mozilla.org, a webapp needs to include https://apps-preview.mozilla.org as an element in the 'installs_allowed_from' property.

That should be changed to:

Error: To be included on https://marketplace.mozilla.org, a webapp needs to include https://marketplace.mozilla.org or a `*' (wildcard) as an element in the 'installs_allowed_from' property.

Changes are:
- update the code that checks this property to allow marketplace.mozilla.org and marketplace-dev.allizom.org as install destinations (IMPORTANT: we should still *allow* apps-preview as a destination because they are demo'ing with that at MWC)
- replace apps-preview with marketplace in the error message
- mention that you can use a * too in the error message

Comment 1

[Matt Basta [:basta]]

Done:

https://github.com/mozilla/amo-validator/pull/129

Comment 2

[Kumar McMillan [:kumar]]

Pushed to AMO https://github.com/mozilla/zamboni/commit/799a0f4