729427 - Incremental GC should mark filenames of newly allocated scripts

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

See bug #641025 comment 124:

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

We also need to mark whenever we look up a filename in the hashtable, since it's effectively a weak pointer.

Comment 2

[Igor Bukanov]

(In reply to Bill McCloskey (:billm) from comment #1)
> We also need to mark whenever we look up a filename in the hashtable, since
> it's effectively a weak pointer.

My plan is to mark newly incremental filename entries under the incremental GC. The rest of cases should be covered by normal marking as the filename is never overwritten. But eventually I want to either remove them or at least turn them into atoms. My initial measurements shows that filename strings are atoms in about 10-15% cases so turning mostly ascii string into UTF16 char array + JSString header should not bloat memory match...

Comment 3

[Igor Bukanov]

Attachment: v1

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 600089 [details] [diff] [review]
v1

Thanks.

Comment 5

[Igor Bukanov]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3b449b1eea2

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/f3b449b1eea2