730051 - Appcrash after bug 728429 landed if Actual Window Manager is enabled

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[TinyButStrong]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120222 Firefox/13.0a1
Build ID: 20120222031223

Steps to reproduce:

Upgrade Nightly to current build (02.23.12).


Actual results:

Crash on startup if Actual Window Manager (trial available in actualtools.com) is enabled.


Expected results:

Not to crash.

Hourly build working http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1329960017/ , crashing one http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1329966198/

Working build c827c52c4603 | crashing 5e756e59a794

Pushlog:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c827c52c4603&tochange=5e756e59a794

Comment 1

[TinyButStrong]

Attachment: App crash screenshot Windows 7 x64.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Our DLL blocklist hook blocks one of their DLLs because SearchPathW can't find it, and then when they try to use it they crash.

Comment 3

[TinyButStrong]

Right, so what's the solution?

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I'm not sure yet.

Comment 5

[TinyButStrong]

Can you back the bug 728429 until a solution is found?

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

No.  If this is a problem you can downgrade to Aurora until this is fixed.

Comment 7

[TinyButStrong]

Should I report the situation to ActualTools or the solution is restrict to Mozilla?

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to TinyButStrong from comment #7)
> Should I report the situation to ActualTools or the solution is restrict to
> Mozilla?

This is our bug.

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Pathless lookups need to work for DLLs that are already loaded.

Comment 10

[Benjamin Smedberg]

Comment on attachment 600442 [details] [diff] [review]
Patch

I don't understand this patch yet: we printf_stderr that we're blocking the load but there's no failure code and we use GetFileVersionInfoSizeW/CheckASLR anyway? This happens in both code blocks...

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #10)
> Comment on attachment 600442 [details] [diff] [review]
> Patch
> 
> I don't understand this patch yet: we printf_stderr that we're blocking the
> load but there's no failure code and we use
> GetFileVersionInfoSizeW/CheckASLR anyway? This happens in both code blocks...

Er, that's just an oversight on my part.  We definitely want to return failure codes there.

Comment 12

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Lets try this again.

Comment 13

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/3a7b9e61c263