730143 - Video links on Creative page appear to be hardcoded

Status: RESOLVED INVALID

(Websites :: Firefox Flicks, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

It appears the links on https://firefoxflicks-dev.allizom.org/en-US/creative#categories are hardcoded for dev; not sure if this is true or not, but looks like it from the HTML source.

<a href="https://firefoxflicks-dev.allizom.org/video/dance/">https://firefoxflicks-dev.allizom.org/video/dance/</a>
      </li>
      <li>
        <a href="https://firefoxflicks-dev.allizom.org/video/twilight/">https://firefoxflicks-dev.allizom.org/video/twilight/</a>
      </li>
      <li>
        <a href="https://firefoxflicks-dev.allizom.org/video/noir/">https://firefoxflicks-dev.allizom.org/video/noir/</a>

Compare also with https://firefoxflicks-dev.allizom.org/en-US/rules.

Comment 1

[Osmose [:osmose, :mkelly]]

The links are generated as part of the view: https://github.com/mozilla/firefox-flicks/blob/master/flicks/base/views.py#L27

Marking as invalid, but they don't need to be absolute links. Feel free to reopen or re-file if we want to make them not absolute.