730200 - bzexport crashes on patches with no description

Status: RESOLVED FIXED

(Developer Services :: Mercurial: bzexport, defect)

Description

[Steve Fink [:sfink] [:s:]]

It's a bad sign when nearly every time I run bzexport, I run into another problem. I should figure out how to set up a test suite. (I have one for part of the functionality, but it's too ugly to land.)

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: imported patch empty-desc

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 600312 [details] [diff] [review]
imported patch empty-desc

Review of attachment 600312 [details] [diff] [review]:
-----------------------------------------------------------------

::: bzexport.py
@@ +952,5 @@
>      if update_patch:
>          # Add "Bug nnnn - " to the beginning of the description
>          ph = mq.patchheader(q.join(rev), q.plainmode)
>          msg = ph.message
> +        if len(msg) == 0:

Make this |if not msg|.