730211 - Drop Windows 2000 support in comm-central

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Makoto Kato [:m_kato]]

Attachment: fix

Gecko drop Windows 2000 support...

Comment 3

[David :Bienvenu]

Comment on attachment 600319 [details] [diff] [review]
fix

Thx for the patch...
Is this patch removing support for the mail unread notifications that work in XP? We're still supporting XP, AFAICT, just not Win 2K. I'm referring specifically to the SHSetUnreadMailCounts removal.

Comment 4

[David :Bienvenu]

the patch builds and runs fine; I'd just like to make sure about the xp/win2k issue.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 600319 [details] [diff] [review]
fix

Review of attachment 600319 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/src/nsMessengerWinIntegration.cpp
@@ +357,5 @@
>  nsMessengerWinIntegration::Init()
>  {
>    nsresult rv;
>  
> +  // load shell dll. If no such dll found, return

Update the comment too or leave the return in.

::: mailnews/base/src/nsMessengerWinIntegration.h
@@ +63,5 @@
>      QUNS_ACCEPTS_NOTIFICATIONS = 5,
>      QUNS_QUIET_TIME = 6
>  } MOZ_QUERY_USER_NOTIFICATION_STATE;
>  
>  // this function is exported by shell32.dll version 5.60 or later (Windows XP or greater)

Nit: Update this comment too.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to David :Bienvenu from comment #3)
> Is this patch removing support for the mail unread notifications that work
> in XP? We're still supporting XP, AFAICT, just not Win 2K. I'm referring
> specifically to the SHSetUnreadMailCounts removal.

They are not removed: they are just used unconditionally now, aren't they?

Comment 7

[David :Bienvenu]

(In reply to Serge Gautherie (:sgautherie) from comment #6)
> 
> They are not removed: they are just used unconditionally now, aren't they?

ah, thx, Serge, I think you're right.

Comment 8

[David :Bienvenu]

Comment on attachment 600319 [details] [diff] [review]
fix

thx for the patch!

Comment 9

[Makoto Kato [:m_kato]]

http://hg.mozilla.org/comm-central/rev/96a18db9f160