Closed
Bug 73028
Opened 23 years ago
Closed 23 years ago
message sending broken if format dialog comes up.
Categories
(MailNews Core :: Composition, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: Bienvenu, Assigned: bugzilla)
Details
(Keywords: smoketest)
Attachments
(2 files)
1.33 KB,
patch
|
Details | Diff | Splinter Review | |
1.70 KB,
patch
|
Details | Diff | Splinter Review |
because of the xul landing, if you try to send html mail to someone and the msg send format dialog pops up, you can't send mail. I have a potential fix for this. However, it's just the tip of the iceberg - mail search is broken, and I think most of the prefs ui is broken too.
Comment 1•23 years ago
|
||
seen this XP: windows 2001-03-22-06-mtrunk linux 2001-03-22-08-mtrunk mac 2001-03-22-04-trunk
Comment 2•23 years ago
|
||
ooops...my bad...linux doesn't even get this far...writing crasher bug for that
Assignee | ||
Comment 3•23 years ago
|
||
All of the mail prefs worked for me in testing, as did search. In class now, will look when I get home.
Assignee | ||
Comment 4•23 years ago
|
||
It seems that some of the mailnews changes were lost or didn't get checked in somehow. I noticed this happened with MsgComposeCommands.js also.
Assignee | ||
Comment 5•23 years ago
|
||
Cc'ing people who can hopefully take a look until I get home (~2 hrs)
Reporter | ||
Comment 6•23 years ago
|
||
Reporter | ||
Comment 7•23 years ago
|
||
it looks to me like radio buttons still use the value setting. I'm also not sure about the first changes (the setAttribute ones). I think it's the getElementById.value change that matters. I tried changing everything over to using data, i.e., the radio group part of askFormat.xul, but that didn't work. I noticed all the other radio group things in prefs were still using "value".
Assignee | ||
Comment 8•23 years ago
|
||
Radio buttons now use label to display the text (instead of value) and value to hold the internal value (instead of data). This fix is on the right track, but the other instances of data in askSendFormat.js need to be changed.
Reporter | ||
Comment 9•23 years ago
|
||
I have to leave for work, so I won't be able to get back to this for an hour or so.
Assignee | ||
Comment 11•23 years ago
|
||
The probable fix for this is known. Can someone make the last few corrections in this file and check this in? I won't be able to for another hour and a half.
Comment 12•23 years ago
|
||
blake, how many more missing checkins do you think there are? If you still have the fixes in your tree and there are many missing files, it might be a good idea to wait for your tested version rather than spot fixing things.
Assignee | ||
Comment 13•23 years ago
|
||
The fixes can't be in my tree, I committed from the top. Some of this may be fallout from the merge conflicts (in the rush to checkin, I may have forgotten to update some cases). In any case, can you please finish the work here and check it in?
Comment 14•23 years ago
|
||
adding the right keyword so this shows up on today's list.
Keywords: smoketest
Reporter | ||
Comment 15•23 years ago
|
||
I'm not going to be able to get to this for a while - I need to update my tree and rebuild, which will take hours, and then I have meetings the rest of the day. So if anyone else has an up to date tree, I'd appreciate it if they could finish my fix.
Comment 16•23 years ago
|
||
fixed. thanks to blake and bienvenu for the patch. I'll attach it so it can be reviewed after-the-fact by the parties that are interested.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 17•23 years ago
|
||
Comment 18•23 years ago
|
||
*** Bug 73041 has been marked as a duplicate of this bug. ***
Comment 19•23 years ago
|
||
verified on the following builds linux-2001-03-26-05 windows-2001-03-23-06(with work around) cannont verify this on mac because of other blocker bugs(73041, 73445)
Comment 20•23 years ago
|
||
marking this bug as verified on mac (buildid: 2001-03-23-10)
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•