730501 - Import/Export feed buttons never enabled after bug 716706

Status: VERIFIED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[:aceman]

The buttons are inoperational and disabled. It seems you wanted to allow them only on the .isServer item in the list (the account name), but that one does return item=undefined. Please check it.

Also the status line could be shown more prominently, or even highlighted when its content (a message) changes. It took me a while to notice where did my alert dialogs go. I thought they are not working.

Comment 1

[alta88]

please don't mix multiple unrelated issues in the same bug.

1. the import/export buttons are intentionally meant to be enabled only upon selection of a root account folder, to make clear to the user the imported tree is a child of that folder (and not a selected subfolder) and that the entire account opml is exported (and not a subfolder subset).

2. i'm not clear on the issue. an action (via button) shows the info message directly above the button so i don't know how it can be missed. anyway, unrelated.

closing; if there is an actual error, please reopen with detailed steps to reproduce.

Comment 2

[:aceman]

I have clicked everywhere in the tree of folders and the buttons were never enabled. Please attach a screenshot where I should click to enable Import and Export buttons.

Comment 3

[alta88]

aha.  the problem is a bad check; if you select the very first tree item, it will be the 0 index and incorrectly fail..  if you add a second feed account and select it, the check will pass.

a fix will be forthcoming.  thanks for the catch.

Comment 4

[alta88]

Attachment: fix.

Comment 5

[:aceman]

Thanks, the fix works for me.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/892d4207a0dd

To make life easier for those checking in patches for you, please follow the directions below to make future patches easier to work with. Thanks!
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F