Closed
Bug 73051
Opened 23 years ago
Closed 23 years ago
Syntax cleanup for the Account Wizard.
Categories
(SeaMonkey :: MailNews: Account Configuration, defect)
SeaMonkey
MailNews: Account Configuration
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stephend, Assigned: stephend)
Details
Attachments
(5 files)
7.29 KB,
patch
|
Details | Diff | Splinter Review | |
14.65 KB,
image/gif
|
Details | |
14.67 KB,
image/gif
|
Details | |
7.62 KB,
patch
|
Details | Diff | Splinter Review | |
2.26 KB,
patch
|
Details | Diff | Splinter Review |
Build ID: ALL, today's. Just general cleanup involving parenthetical statements and where periods should lie. Patch next.
Assignee | ||
Updated•23 years ago
|
QA Contact: esther → nbaca
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
Assignee | ||
Comment 3•23 years ago
|
||
Assignee | ||
Comment 4•23 years ago
|
||
Note: with this new patch, because the parenthetical statement is now part of a regular sentence, the spacing becomes a little bit off in the default size of the window (see screenshots). If you resize the window, it's not a problem.
Assignee | ||
Comment 5•23 years ago
|
||
Robin, this is perhaps hard to see in a patch only. If you would like to come review it on my build here, I'd be happy to show it to you. Thanks.
r=robinf (reviewed the fixes in Stephen's debug build on his machine).
Assignee | ||
Comment 7•23 years ago
|
||
Seth, can you sr= this please? Thanks.
Comment 8•23 years ago
|
||
stephend: while you're at it, can you change the sample URIs in the text to point to one of either "example.org", "example.net", "example.com", or, if applicable, "domain.invalid"? In particular, emailExample.label and the comment before it should be changed so that the e-mail address is "user@example.net", incomingServerNameDesc.label and its comment should be changed so that the POP server is "pop.example.net", newsServerNameDesc.label and the comment before it should be changed to read "news.example.net", and smtpServerDesc.label and its comment should have the server name changed to "smtp.example.net". See RFC2606 and bug 71121 for details.
Assignee | ||
Comment 9•23 years ago
|
||
Comment 10•23 years ago
|
||
You missed a comment ("<!-- LOCALIZATION NOTE (incomingServerNameDesc.label)"), otherwise looks ok. I don't know anything about XUL DTDs or .properties files though, so I'm not really qualified to give an r=. Thanks!
Assignee | ||
Comment 11•23 years ago
|
||
sr=shaver.
Assignee | ||
Comment 13•23 years ago
|
||
Fix checked in. Thanks to Robin, Ian, and Mike for speedy reviews.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 14•23 years ago
|
||
Build 2001-04-03-04: NT4 Build 2001-04-03-05: Linux RH 6.2 Build 2001-04-02-08: Mac 9.04 Verified Fixed.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•