730526 - Cleanup and idiom in BrowserProvider.java.in

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Richard Newman [:rnewman]]

Spotted a niggle with how the projection maps are initialized, and figured I'd do some cleanup.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

* MPL 2.0
* Use least-specific interface for provider column members (which allows for implementation switchout, and discourages perception of mutability)
* Use "create-modify-set" idiom for static initialization, rather than "create-set-modify"
* Use `unmodifiableMap` (alongside `final`) to ensure immutability.

Comment 2

[Richard Newman [:rnewman]]

Attachment: Rebased. v2

Had to adjust this on top of the GeckoProfile change.

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 600826 [details] [diff] [review]
Rebased. v2

Review of attachment 600826 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 4

[Richard Newman [:rnewman]]

Thanks Lucas!

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f4106533b30

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/0f4106533b30

Comment 6

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 13.0a1 (2012-03-05)
20120305031045
http://hg.mozilla.org/mozilla-central/rev/433cfbd2a0da

--
Device: HTC Desire
OS: Android 2.2