730532 - remove CSS2Properties aliases for MozOpacity and MozOutline*

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I just noticed that in bug 413141 and bug 458588 we didn't drop the CSS2Properties aliases for the CSS aliases that we removed.

CSS2Properties aliases are also in multiple places; they're getting to be a bit of a pain to edit.

So I have:
 (1) a patch to make CSS aliases be driven by a header file (though, until bug 698072, we'll still have to edit nsIDOMCSS2Properties.idl).  This temporarily fully readds the aliases partially removed above
 (2) A patch to fully remove the aliases above.

Testing with only patch (1) and with both patches ensures that my header file approach works both with and without aliases.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Add a header file for CSS property aliases (and temporarily resurrect the aliases whose DOM properties we forgot to remove). (, patch 1)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Remove the CSS2Properties aliases for MozOutline* and MozOpacity for CSS properties whose CSS aliases were removed long ago (but temporarily readded in the previous changeset). (, patch 2)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Fix uses of removed CSS2Properties.MozOutline DOM property (replaced by outline). (, patch 3)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 600604 [details] [diff] [review]
Add a header file for CSS property aliases (and temporarily resurrect the aliases whose DOM properties we forgot to remove).  (, patch 1)

r=me

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 600605 [details] [diff] [review]
Remove the CSS2Properties aliases for MozOutline* and MozOpacity for CSS properties whose CSS aliases were removed long ago (but temporarily readded in the previous changeset).  (, patch 2)

r=me

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffc9d929b260
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cbf894da185

Comment 7

[Mihai Sucan [:msucan]]

Comment on attachment 600606 [details] [diff] [review]
Fix uses of removed CSS2Properties.MozOutline DOM property (replaced by outline).  (, patch 3)

Thanks for the patch!

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Mihai Sucan [:msucan] from comment #7)
> Comment on attachment 600606 [details] [diff] [review]
> Fix uses of removed CSS2Properties.MozOutline DOM property (replaced by
> outline).  (, patch 3)
> 
> Thanks for the patch!

And, to be clear:  if upstream cares about supporting versions of Firefox prior to 1.5 (i.e., prior to bug 281972), then they don't want this patch.  It's not clear to me if they do.

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ffc9d929b260
https://hg.mozilla.org/mozilla-central/rev/9cbf894da185

Comment 10

[Mihai Sucan [:msucan]]

(In reply to David Baron [:dbaron] from comment #8)
> (In reply to Mihai Sucan [:msucan] from comment #7)
> > Comment on attachment 600606 [details] [diff] [review]
> > Fix uses of removed CSS2Properties.MozOutline DOM property (replaced by
> > outline).  (, patch 3)
> > 
> > Thanks for the patch!
> 
> And, to be clear:  if upstream cares about supporting versions of Firefox
> prior to 1.5 (i.e., prior to bug 281972), then they don't want this patch. 
> It's not clear to me if they do.

Orion aims for compatibility with much newer Firefox releases. Orion 0.3 had a minimum requirement of Firefox 5. Orion 0.4 (the current release being worked on) requires Firefox 8.

Reported this bug upstream:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=372665

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd4253db247d

Comment 12

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/dd4253db247d

Comment 13

[Eric Shepherd [:sheppy]]

The affected interface isn't documented, so all I did was mention this change on Firefox 13 for developers.