730701 - Difficult to determine active tab. Insufficient color contrast.

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Wayne Mery (:wsmwk)]

Attachment: screen shot of tbird, chrome, firefox tabs

Difficult to determine active tab.  Insufficient color contrast.

This is on Vista using Vista Windows Classic Theme.
Thunderbird 13, default theme.

Comment 1

[rsx11m]

This depends on the desktop theme. It's ok on Windows 7 Aero but looks like Wayne describes it on Windows Classic and Windows 7 Basic.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Fix the tabs

Removed the :not(:-moz-lwtheme) rules and moved the properties to the right positions to work better also under classic.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 600813 [details] [diff] [review]
Fix the tabs

After a giant amount of work getting my Windows build, uh, building, I've finally taken a look at the patch.

It seems to fix the problem, and doesn't look horrible, so ui-r=me.  ;)

>+++ b/mail/themes/qute/mail/tabmail-aero.css

So, given that the problem only exists in classic mode, I'm not sure why you're changing tabmail-aero.css.
(I've also looked through the various Windows themes, and can't see the difference.)

Uh, but I do see the difference in classic mode, and there aren't any changes to tabmail.css, so now I'm _really_ confused.

If you can explain that (and I'm happy with the explanation), then I'll change to an r+, but for now, I've got to say r-.

Thanks,
Blake.

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 600813 [details] [diff] [review]
Fix the tabs

(No, I actually meant "r-".)

Comment 5

[Richard Marti (:Paenglab)]

Under XP everything is okay and here the file tabmail.css is used. Under Vista/Win7 only the file tabmail-aero.css is used, also in classic mode. Because of this I had to change the wrong rules only in tabmail-aero.css

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 600813 [details] [diff] [review]
Fix the tabs

Okay, that makes sense.  r=me!

Thanks,
Blake.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/4a2284b77786