730739 - Provide visual indication when a bookmark search keyword is typed in the awesomescreen

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Paul [pwd]]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20120224 Firefox/13.0a1
Build ID: 20120224040232

Steps to reproduce:

On desktop and xul you can perform a quick search via the awesomebar. This is a feature that Fennec doesn't appear to support and should.

Comment 1

[Matt Brubeck (:mbrubeck)]

Do you mean bookmark keywords, or something else?  Support for bookmark keyword search was added in bug 722184, though there's no UI to add keywords in Fennec.  (You can only sync them from desktop.)

If you mean searching just by typing a query directly into the awesomebar, this should work in all versions of Fennec using the "keyword.URL" pref (set to Google by default).

Comment 2

[Paul [pwd]]

Yup keyword searches. If I set one up for IMDB for example, on desktop I type IMDB and then get a search much like those present in Fennec. A clickable item. However in Fennec the list of suggestions completely clears out and I'm asked if I want to search Google, Amazon, etc. There's no visual confirmation of what you're doing whatsoever.

Comment 3

[Doug Turner (:dougt)]

ian, any thoughts?  Do you think this must block shipping?  I didn't.

Comment 4

[Ian Barlow (:ibarlow)]

I quite like this idea, but I also agree that it shouldn't block our first release. 

You can keep it assigned to me, though, I'll post some UI for it when I can.

Comment 5

[Paul [pwd]]

I was thinking this could be a [good first bug] nomination?

The logic required would be if keyword matched, create row on awesomescreen, fetch favicon and if that's available display that with the name of the bookmark and the search term having removed the keyword.

Comment 6

[:Margaret Leibovic]

I could help mentor this bug (or bnicholson, since this sounds similar to the UI work that went into search suggestions), but we'd need some mockups from Ian to know what this should actually look like.

Comment 7

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.