73099 - new cache problems with bugzilla

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect)

Description

[(not reading, please use [e-mail] instead)]

view a bugzilla report, add a comment, submit, close the window.

open the report again, you get the version you loaded before, prior to your comment.

add a new comment, collision with your last comment.

zoinks!

Comment 1

[neeti]

-->gordon

Comment 2

[Darin Fisher]

sounds more like an HTTP bug to me... investigating.

Comment 3

[Darin Fisher]

there is a problem with the cache validation setting of "once per session"
we compare the session start time against the last modified time of the cache
entry, and it looks like the cache entry is always modified!  not sure if this
is http's fault or the cache's.  investigating...

Comment 4

[Darin Fisher]

*** Bug 73417 has been marked as a duplicate of this bug. ***

Comment 5

[Darin Fisher]

ok.. this is not an HTTP bug.  the disk cache calls SetDataSize() and SetData()
on disk cache entries while reading the data from disk (readDiskCacheEntry).
this results in the lastModified time stamp being updated.  this is not
correct, since lastModified should only be updated to reflect the last time
the cache client (in this case HTTP) modified the cached data.

gordon: cache entry descriptor needs to tell the cache entry when to update
its last modified time stamp.  it doesn't make sense for the cache entry to
try to do this automagically.

Comment 6

[Asa Dotzler [:asa]]

this is dogfood for someone who spends his day in Bugzilla. 

Comment 7

[gordon]

Darin, this has already been fixed on the DISKCACHE1_BRANCH, which we hope to 
land in the next day or so.

Comment 8

[Darin Fisher]

my fix for bug 73490 should make this bug appear to be fixed.

Comment 9

[Gagan]

gordon: make sure this problem is fixed WITHOUT darin's fix of bug 73490 since 
his fix will mask this to be less frequently visible and make you believe that 
this is fixed.

Comment 10

[Darin Fisher]

this bug can be verified using about:cache.  upon revisiting a cached page,
the last-modified time stamp should not change, unless the page was refetched
or validated with the server.  changing your cache preferences to validate
never should help make verification easier.

Comment 11

[gordon]

Fix checked in.

Comment 12

[scottputterman]

*** Bug 73921 has been marked as a duplicate of this bug. ***

Comment 13

[Darin Fisher]

*** Bug 73924 has been marked as a duplicate of this bug. ***

Comment 14

[Tom Mraz]

Verified Linux 2001062021