731023 - Remove devicemanager's communicate method

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[William Lachance (:wlach)]

It's a confusing method (assuming that output from a running process goes to a file called "temp.txt". Nothing uses it in mozilla-central (or talos).

Comment 1

[William Lachance (:wlach)]

(In reply to William Lachance (:wlach) from comment #0)
> It's a confusing method (assuming that output from a running process goes to
> a file called "temp.txt". Nothing uses it in mozilla-central (or talos).

... except for a test program which doesn't even work, which I will also remove as part of this patch.

Comment 2

[William Lachance (:wlach)]

Attachment: Very straightforward patch to remove unused method

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 601106 [details] [diff] [review]
Very straightforward patch to remove unused method

Review of attachment 601106 [details] [diff] [review]:
-----------------------------------------------------------------

can you run this through try server?

Comment 4

[Mozilla RelEng Bot]

Try run for 32695b4648e5 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=32695b4648e5
Results (out of 29 total builds):
    exception: 2
    success: 24
    warnings: 2
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-32695b4648e5

Comment 5

[William Lachance (:wlach)]

(In reply to Mozilla RelEng Bot from comment #4)
> Try run for 32695b4648e5 is complete.
> Detailed breakdown of the results available here:
>     https://tbpl.mozilla.org/?tree=Try&rev=32695b4648e5
> Results (out of 29 total builds):
>     exception: 2
>     success: 24
>     warnings: 2
>     failure: 1
> Builds (or logs if builds failed) available at:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/wlachance@mozilla.
> com-32695b4648e5

Everything looks good here, except for the usual intermittent failures.

Comment 6

[cmtalbert]

m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/0983ca6b6ce6

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/0983ca6b6ce6