Closed Bug 731109 Opened 12 years ago Closed 12 years ago

Treat add-ons using require("window-utils") and require("observer-service") the same as those using require("chrome")

Categories

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Product:
addons.mozilla.org Graveyard
Component:
Add-on Validation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kmag, Assigned: basta)

Details

(Whiteboard: [ReviewTeam:P2]) 

The window-utils and observer-service modules allow access to relatively unsafe and unstable Gecko innards in the same way as require("chrome"). They allow add-ons to leak in difficult to detect ways and to use APIs which are likely to change. Imports of those modules should be flagged the same as require("chrome") and the add-ons should be kept from the Fast Track queue.

CCing the editors from the Jetpack team in case there are other modules which should be treated similarly or they have other input.
Assignee: nobody → mattbasta
Whiteboard: [ReviewTeam:P2]
Target Milestone: --- → Q1 2012
Fixed: https://github.com/mozilla/amo-validator/commit/76ac7c135e2381d7ece875d2377148de978ea967

Pushed to AMO: https://github.com/mozilla/zamboni/commit/e3f1f1a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: Q1 2012 → 6.4.7
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.