Closed
Bug 731157
Opened 12 years ago
Closed 12 years ago
[New Tab Page] thumbnails disappear when switching to private browsing mode
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 15
People
(Reporter: virgil.dicu, Assigned: raymondlee)
References
Details
(Keywords: uiwanted)
Attachments
(1 file)
1.80 KB,
patch
|
dao
:
feedback-
|
Details | Diff | Splinter Review |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120227 Firefox/13.0a1 When opening a new tab in private browsing, none of the sites in the grid will display thumbnails. While this seems normal as the cache doesn't seem to be used, the page does not look very user friendly for a first experience with Private browsing. Wouldn't showing a blank new tab page or the private browsing notification fit in better with browsing in private? FTR, Chrome displays a notification when opening a new tab in incognito mode.
Comment 1•12 years ago
|
||
So a better Summary would rather be "disable the New Tab Page in Private Browsing Mode", no?
Comment 2•12 years ago
|
||
Yes. What does the UX team think about this proposal? We could just switch to 'about:blank' when we're in private browsing mode. Otherwise it might make sense to display an immutable 'about:newtab' page when in PB mode to give you access to your bookmarks/sites.
What Chrome does isn't bad : it always display the private browsing message when a new tab is opened.
Comment 4•12 years ago
|
||
As an easy fix for this, we can default to 'about:blank' for a new tab when the user is in private mode. Longer term, we can be more explicit about private mode and messaging.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → raymond
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•12 years ago
|
||
Tim: do you think it would be better to create a new JSM. This singleton class would has a observer to listen to private-browsing preference and update the "browser.newtab.url" when needed?
Attachment #617828 -
Flags: feedback?(ttaubert)
Comment 6•12 years ago
|
||
Comment on attachment 617828 [details] [diff] [review] v1 Add-ons can modify browser.newtab.url, so you don't want to just clobber it. Secondly, changing browser.newtab.url isn't going to be compatible with the private browsing mode becoming window-specific. Finally, is this still needed at all with the upcoming custom thumbnail storage?
Attachment #617828 -
Flags: feedback-
Comment 7•12 years ago
|
||
Comment on attachment 617828 [details] [diff] [review] v1 (In reply to Dão Gottwald [:dao] from comment #6) > Finally, is this still needed at all with the upcoming custom thumbnail > storage? Actually, yes, this should be solved with the new storage as we're able to show thumbnails then. Let's not continue to work on this but wait for the storage to be fixed.
Attachment #617828 -
Flags: feedback?(ttaubert)
Updated•12 years ago
|
Depends on: 744388
Summary: [New tab page] Disable the New Tab Page in Private Browsing Mode → [New Tab Page] thumbnails disappear when switching to private browsing mode
Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → NEW
Comment 8•12 years ago
|
||
Fixed by bug 744388.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Target Milestone: --- → Firefox 15
You need to log in
before you can comment on or make changes to this bug.
Description
•