731219 - XMLRPC content-type verification fails if a charset is provided

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect, P1)

Description

[:glob ✱]

following the change in bug 725663, if an xmlrpc client sets the charset as part of its content-type header, we're incorrect rejecting the request.

for example, ruby's xmlrpc library sends a content-type of "text/xml; charset=utf-8" which results in "Only text/xml and application/xml are allowed."

Comment 1

[:glob ✱]

Attachment: patch v1

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 601276 [details] [diff] [review]
patch v1

Review of attachment 601276 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and passes testing r=dkl

Comment 5

[Reed Loden [:reed]]

This needs to be immediately pushed to bmo, as it's causing major production issues for webtools that use the API.

Comment 6

[:glob ✱]

(In reply to Reed Loden [:reed] (very busy) from comment #5)
> This needs to be immediately pushed to bmo, as it's causing major production
> issues for webtools that use the API.

agreed; i'll liaise with IT and get this pushed soon.
we should also release 4.0.6 and 4.2.1

Comment 7

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified Bugzilla/WebService/Server/XMLRPC.pm
Committed revision 7699.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified Bugzilla/WebService/Server/XMLRPC.pm
Committed revision 8042.

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/WebService/Server/XMLRPC.pm
Committed revision 8138.

Comment 8

[:glob ✱]

(In reply to Byron Jones ‹:glob› from comment #6)
> (In reply to Reed Loden [:reed] (very busy) from comment #5)
> > This needs to be immediately pushed to bmo, as it's causing major production
> > issues for webtools that use the API.
> 
> agreed; i'll liaise with IT and get this pushed soon.

this fix is now live on bmo.